PR Concerns & Justifications

This PR introduces support for the GKE Accelerator Network Profile (ANP) feature, for the GA release. There are two key changes that require special attention:

1. Change: additional_node_network_config from ForceNew to Computed

• Justification: This change is essential for the ANP feature to function correctly. When a nodepool is created with an accelerator_network_profile, GKE automatically provisions an additional_node_network_config on the backend.

• The Problem: If this attribute remains ForceNew, Terraform will detect a difference between the (empty) configuration and the auto-provisioned config returned by the API. This will cause any subsequent terraform apply or import to fail, as Terraform will try to recreate the resource.

• The Solution: By changing this to Computed, we allow Terraform to acknowledge that this value is generated and managed by the GKE API after the resource is created. This resolves the persistent diff and allows the resource to be managed correctly.

• On Missing Test Reports: This fundamental change to the attribute's behavior may impact existing acceptance tests for additional_node_network_config. I am seeking advice on the best path forward to update them.

2. Change: Alpha API Version Guard for accelerator_network_profile

• Context: The GKE Accelerator Network Profile feature was announced for Public Preview (as of Oct 16th), but the corresponding accelerator_network_profile field is not available in the GKE V1 or V1Beta1 API track yet as of today.

• The Action: Currently, in order to not trigger any V1 or V1Beta1 tests error, I marked the version guard flag as {{- if eq $.TargetVersionName "alpha" }} since "alpha" is not in any of the version guard categories.

• Remaining Question: While waiting for the V1 API to be populated, I am seeking advice on the best path forward to correctly implement the ANP Terraform support.

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 784 insertions(+))
google-beta provider: Diff ( 7 files changed, 1038 insertions(+))

Missing doc report (experimental)

The following resources have fields missing in documents.

• google_container_cluster
  • Expected Document Path: /website/docs/r/container_cluster.html.markdown
  • Fields: [node_pool.network_config.accelerator_network_profile]

Tests analytics

Total tests: 278
Passed tests: 261
Skipped tests: 15
Affected tests: 2

Action taken

Get to know how VCR tests work

🟢 Tests passed during RECORDING mode:
TestAccContainerCluster_nodePool_acceleratorNetworkProfile_Lifecycle [Debug log]
TestAccContainerNodePool_acceleratorNetworkProfile_Lifecycle [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

@ellenjzh looks like a bunch of tests failed because of this (e.g., hashicorp/terraform-provider-google#25898 and similar). Was this submitted too soon? Not sure if this was ready to be usable yet.

@ellenjzh looks like a bunch of tests failed because of this (e.g., hashicorp/terraform-provider-google#25898 and similar). Was this submitted too soon? Not sure if this was ready to be usable yet.

I see the error here, GA tests didn't pass because I didn't add the GA version guards. The feature is only available in Beta. I will add the GA version guards to the tests now.